feat(project)!: Remove "put-several" mechanic #1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustebaum
force-pushed
the
remove-put-several-mechanic-from-project
branch
from
b7bf565 to
a18abec
Compare
augustebaum
changed the title
Contributor
Coverage Report for backend
|
thomass-dev
reviewed
Jan 14, 2025
thomass-dev
reviewed
Jan 14, 2025
This is for several reasons: - it is not as explicit as several simple `put` calls: the mechanic is ambiguous with regards to atomicity (if a key-value pair is invalid, does it make the whole operation fail?) - the mechanic makes it complicated to add options to `put`, e.g. the `note` option proposed in #1041 or the `display_as` option proposed in #1045 (comment).
augustebaum
force-pushed
the
remove-put-several-mechanic-from-project
branch
from
a18abec to
6a18fb4
Compare
waridrox
pushed a commit
to waridrox/skore
that referenced
this pull request
Apr 15, 2025
This is for several reasons: - it is not as explicit as several simple `put` calls: the mechanic is ambiguous with regards to atomicity (if a key-value pair is invalid, does it make the whole operation fail?) - the mechanic makes it complicated to add options to `put`, e.g. the `note` option proposed in probabl-ai#1041 or the `display_as` option proposed in probabl-ai#1045 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for several reasons:
putcalls: the mechanicis ambiguous with regards to atomicity (if a key-value pair is
invalid, does it make the whole operation fail?)
put,e.g. the
noteoption proposed inAnnotate the version of an item #1041
or the
display_asoption proposed infeat: As a user, i want to retrieve a
CrossValidationReporterfrom a project #1045 (comment).